]]>
For knowledge durability reasons, you have to know that important informations evoked in this conversation are now wikified.
wiki::sdk::usine architecture
Of course, you have rights and duties to consult, modify and make alive these informations
Statistics: Posted by martignasse — 13 May 2009, 11:05
]]>
but don't forget that there is a time jitter, due to the sound card latency and the multi thread core. For example Usine can process 2 blocs very quickly and then wait few ms before treat another set of 2 blocs...
Statistics: Posted by senso — 13 May 2009, 09:07
]]>
seems you've got confirmation from senso in the other thread that the process function is called every BLOC samples. I prefer that the info come from senso, as he is the one who know all that stuff, i'm like you, discovering the beast (not senso...Usine"process" is called syncronicall with the block size?
ie. if the block size is 128, audio process is called every 128 samples?
Or, if the sample rate is 44100 and "process" is called 800/sec, the audio array is around 55 samples?(but, normally, it can't be less than the block size)
)yep, the SDK itself is in C++, but the brunch of functions to communicate with usine (at the end of the UserDefinitions.h) use C signature. Anyway, not very relevant, should be pretty tired when i wrote that, sorrysorry, I don't understand: this SDK is C++, right? What do you mean with SDK interface?
I'm impatient to see your modules
Statistics: Posted by martignasse — 12 May 2009, 20:29
]]>
"process" is called syncronicall with the block size?3/ Process <- called each Usine cycle (800/second) while your module is alive
ie. if the block size is 128, audio process is called every 128 samples?
Or, if the sample rate is 44100 and "process" is called 800/sec, the audio array is around 55 samples?(but, normally, it can't be less than the block size)
??? sorry, I don't understand: this SDK is C++, right? What do you mean with SDK interface?(don't miss the SDK interface is C, not C++)
that's true....What prevent you to split that in two param ? like a 'base freq' one who is a value of the wanted reference frequence and a 'mod' one who is a signal of the modulation wanted around the 'base freq' value.
thanks again
Statistics: Posted by Gizzeta — 08 May 2009, 23:54
]]>
The module is a simple oscillator. It fill a buffer with a file where there's a one-cycle waveform.
Then it calculates wich sample he has to put out, according with the actual frequency parameter.
ok, it's what i supposedThen it calculates wich sample he has to put out, according with the actual frequency parameter.
Good question, i dont know the exact order, but i'm sure of that :Can you explain me the exact order in wich the finctions are called by Usine? (I guess: "Create", then "getModuleInfo", then "initModule"....)
1/ Create
2/ InitModule,
3/ Process <- called each Usine cycle (800/second) while your module is alive
4/ Destroy
eventually:
CallBack is called by usine each time a param is modified in the module parameters panel
for the rest, i 'm not sure, i'll try to make a time sequenced diagram in the wiki,
Yep, static variables are created in the static memory, shared by all functions (don't miss the SDK interface is C, not C++)So a variable declared as static is shared by all instances? (I'm sorry, I'm a c++ beginner...)
the simple way is to declare it in your module definition (the include file), and initialise it in the InitModule function if you need some infos stored in pMasterInfoAnd if I want a variable, private to the module, that keep the value between more functions calls, I have to declare it in the "create" function? And it can be a normal (not pointer) variable?
in the include file :
CODE:
class MuModule : public TUserModule{...private:intiMyVariable;...};CODE:
...//-----------------------------------------------------------------------------// initialisationvoid InitModule (void* pModule, TMasterInfo* pMasterInfo, TModuleInfo* pModuleInfo) {// conveinient pointer MyModule* pMyModule = ((MyModule*)pModule);// remember, it's up to us to initialise the pMasterInfo poimnter herited from TUserModulepMyModule->pMasterInfo = pMasterInfo;// initialisation of other variablepMyModule->iMyVariable = pMasterInfo->pTimeInfo->sampleRate; // or whatever, you got the idea}...well, it's here your design is not very clear, i think, you have two signification for the same param, it's not clean.It's a pDataFader. Because I want that it could be possible to control the module frequency by a data value and by a signal value (for frequency modulation, eg: at every sample the frequency value can variate).
So, if the incoming data is a single value (len == 1), it's a normal data frequency control. In this case I calculate (pFreqIn*samplesOverSR) just once for "process" call.
If the incoming data is an array whose lenght is the same as Block Size, it's a frequency modulation and (pFreqIn*samplesOverSR) has to be calculated once for sample.
Finally, if there's no cable connected, I want the module to out a 0.f signal (silence).
What prevent you to split that in two param ? like a 'base freq' one who is a value of the wanted reference frequence and a 'mod' one who is a signal of the modulation wanted around the 'base freq' value.
but Usine provide different params for differents kind of signal, like said above. seems like your design push you to make extra work here.I detect what kind of message (data or signal) is coming in, by the size if the 'pCycle->pFreqIn'.
not automaticly, for your case, it's once again the design who push you to make like that. In your Process function, there is some mix between the detection of the param (data or signal) and the audio treatment, it make the code trickyDo you think it's better to create a function on purpose?
Statistics: Posted by martignasse — 08 May 2009, 17:38
]]>
The module is a simple oscillator. It fill a buffer with a file where there's a one-cycle waveform.
Then it calculates wich sample he has to put out, according with the actual frequency parameter.
1°)
that's what I want. lSize/SR is always the same, for all the module duration. I calculate it only at creation, to economize CPU.'samplesOverSR' is never updated with the '(float)*(pCycle->lSize) / (float)pCycle->pMasterInfo->pTimeInfo->sampleRate' result.
Maybe can I initialize it in the "InitModule" function?
Can you explain me the exact order in wich the finctions are called by Usine? (I guess: "Create", then "getModuleInfo", then "initModule"....)
I thik this was my problem...More than that, as 'samplesOverSR' is declared static, only one instance of it is shared by all instances of your modules.
So a variable declared as static is shared by all instances? (I'm sorry, I'm a c++ beginner...)
And if I want a variable, private to the module, that keep the value between more functions calls, I have to declare it in the "create" function? And it can be a normal (not pointer) variable?
2°)
It's a pDataFader. Because I want that it could be possible to control the module frequency by a data value and by a signal value (for frequency modulation, eg: at every sample the frequency value can variate).What kind of datatype is your 'pFreqIn' param ?
So, if the incoming data is a single value (len == 1), it's a normal data frequency control. In this case I calculate (pFreqIn*samplesOverSR) just once for "process" call.
If the incoming data is an array whose lenght is the same as Block Size, it's a frequency modulation and (pFreqIn*samplesOverSR) has to be calculated once for sample.
Finally, if there's no cable connected, I want the module to out a 0.f signal (silence).
3°)
..hem...I don't understend...I detect what kind of message (data or signal) is coming in, by the size if the 'pCycle->pFreqIn'.'pCycle->pFreqIn->len' is initially used to store the size of the DATA array of 'pCycle->pFreqIn', but you use it also to detect if you make data or audio treatment.
Empircally, I found that I have to set to 0 the 'pCycle->pFreqIn->len' at the end of each "process" call. Otherwise if a cable is not connected, it keep the last lenght.
Do you think it's better to create a function on purpose?- avoid duplication of same code,
In term of CPU economy what is more expensive: a class/structure member calls or a variable more?- reduce the use of class/structure member call for reading info in 'for' loop, make variable for it before the loop, for exampleit make code more readable and optimized, if your BlockSize is 512, you save 512 class/structure member calls.CODE:
int iAudioOutLen = pCycle->pAudioOut->len = pCycle->pMasterInfo->BlocSize;int i ;...for (i = 0; i < iAudioOutLen ) { ...}
really thanks for your counsels!
Statistics: Posted by Gizzeta — 08 May 2009, 14:44
]]>
1°)
CODE:
static float samplesOverSR = (float)*(pCycle->lSize) / (float)pCycle->pMasterInfo->pTimeInfo->sampleRate;More than that, as 'samplesOverSR' is declared static, only one instance of it is shared by all instances of your modules.
Is it the intended behavior ?
2°)
What kind of datatype is your 'pFreqIn' param ?
It seems you use it sometime for data, sometime for audio buffer (strange and potentially dangerous) but i can't see what kind of param is used, array maybe ?
3°)
in general, your code is hard to read and understand, i can't even know what you exactly do just by reading it
Try to let things simple and clear. For this, here some general rules :
- one meaning by variable, it preserve you from unwanted side effect and make readability better, for example, 'pCycle->pFreqIn->len' is initially used to store the size of the DATA array of 'pCycle->pFreqIn', but you use it also to detect if you make data or audio treatment.
- avoid duplication of same code, for example, you surely can avoid the double time use of this block (used in your 'if' AND 'else' statement)
CODE:
pCycle->pAudioOut->DATA[i] = *(pCycle->buffer + (int)*(pCycle->index)); *(pCycle->index) += *(pCycle->coefFreq); if(*(pCycle->index) >= *(pCycle->lSize)) *(pCycle->index) -= *(pCycle->lSize);- reduce the use of class/structure member call for reading info in 'for' loop, make variable for it before the loop, for example
CODE:
int iAudioOutLen = pCycle->pAudioOut->len = pCycle->pMasterInfo->BlocSize;int i ;...for (i = 0; i < iAudioOutLen ) { ...}Hope it help
Statistics: Posted by martignasse — 08 May 2009, 11:27
]]>
Statistics: Posted by Gizzeta — 08 May 2009, 02:13
]]>
]]>
...maybe you haven't seen my previous post...I have put the whole code...no problem, but remenber to ask someone else to read your code
Statistics: Posted by Gizzeta — 07 May 2009, 22:59
]]>
...forgot:
no problem, but remenber to ask someone else to read your code it save days, no joke !no, there is no need to make complex things like that.lSize is a pointer because I need to access to it in the process function. It's the only way, isn't it?
the process function provide one parameter, a pointer to void who is a pointer to your user module, you have just to cast it conveiniently.
CODE:
TMyModule* pMyModule = ((TMyModule*)pModule);CODE:
nt local_int_value_of_lSize = pMyModule->lSize;CODE:
pMyModule->lSize = 3;generally, pointer are conveinient for composite variable (like structure, or class) which is not the case of an int.
hope it enlight you
Statistics: Posted by martignasse — 07 May 2009, 21:45
]]>
Statistics: Posted by Gizzeta — 07 May 2009, 21:06
]]>
CODE:
class TCycle : public TUserModule{public:TEVT* pFreqIn;TEVT* pAudioOut;FILE* pFile;float* buffer, *index, *coefFreq, *freqMinus;int* lSize;};void Process (void* pModule) {//pointer to the moduleTCycle* pCycle = ((TCycle*)pModule);static float samplesOverSR = (float)*(pCycle->lSize) / (float)pCycle->pMasterInfo->pTimeInfo->sampleRate;int i;pCycle->pAudioOut->len = pCycle->pMasterInfo->BlocSize;// data type CONNECTEDif(pCycle->pFreqIn->len == 1){if(pCycle->pFreqIn->value != *(pCycle->freqMinus)){*(pCycle->freqMinus) = pCycle->pFreqIn->value;*(pCycle->coefFreq) = pCycle->pFreqIn->value * samplesOverSR;}for(i = 0; i < pCycle->pMasterInfo->BlocSize; i++){pCycle->pAudioOut->DATA[i] = *(pCycle->buffer + (int)*(pCycle->index));*(pCycle->index) += *(pCycle->coefFreq);if(*(pCycle->index) >= *(pCycle->lSize)) *(pCycle->index) -= *(pCycle->lSize);}}// audio type CONNECTEDelse if(pCycle->pFreqIn->len == pCycle->pMasterInfo->BlocSize){for(i = 0; i < pCycle->pMasterInfo->BlocSize; i++){if(pCycle->pFreqIn->DATA[i] != *(pCycle->freqMinus)){*(pCycle->freqMinus) = pCycle->pFreqIn->DATA[i];*(pCycle->coefFreq) = pCycle->pFreqIn->DATA[i] * samplesOverSR;}pCycle->pAudioOut->DATA[i] = *(pCycle->buffer + (int)(*(pCycle->index)));*(pCycle->index) += *(pCycle->coefFreq);if(*(pCycle->index) >= *(pCycle->lSize)) *(pCycle->index) -= *(pCycle->lSize);}}// NO CABLE CONNECTEDelse{for(i = 0; i < pCycle->pMasterInfo->BlocSize; i++) pCycle->pAudioOut->DATA[i] = 0.f;};pCycle->pFreqIn->len = 0;} void Create(void* &pModule) { pModule = new TCycle(); TCycle* pCycle = ((TCycle*)pModule); size_t result; pCycle->lSize = new int; pCycle->pFile = fopen ( "E:\AUDIO\USINEfiles\Cycle\Sine2048.bin" , "rb" ); assert(pCycle->pFile != NULL); //obtain file size: fseek (pCycle->pFile , 0 , SEEK_END); *(pCycle->lSize) = ftell (pCycle->pFile); *(pCycle->lSize) /= sizeof(float); rewind (pCycle->pFile); // allocate memory to contain the whole file: pCycle->buffer = new float[sizeof(float)*(*(pCycle->lSize))]; // copy the file into the buffer: result = fread (pCycle->buffer,sizeof(float),*pCycle->lSize,pCycle->pFile); //variables declaration and initialization (used only in "process" function)pCycle->index = new float;*(pCycle->index) = 0.f; pCycle->coefFreq = new float;pCycle->freqMinus = new float;*(pCycle->freqMinus) = 0.f; //close fclose (pCycle->pFile);}void Destroy(void* pModule) {TCycle* pCycle = ((TCycle*)pModule);delete pCycle->lSize;delete pCycle->buffer;delete pCycle->index;delete pCycle->coefFreq;delete pCycle->freqMinus;delete pModule;}Normally if I declare a variable in the process function, it's not global in Usine, isn't it?
Statistics: Posted by Gizzeta — 07 May 2009, 20:55
]]>
but in fact, without shown code, those bugs are very difficult to found. There is surely something in your 'more complex' object that is to obvious to be seen by you (lots of internal automatism when coding), but easily by another one, i mean, someone who not wrote the code !
The most important is that you solved your problem, so
Statistics: Posted by martignasse — 07 May 2009, 19:19
]]>
I have others variables declared in the process function. I thought that theese were not global...(isn't it?)
So, I declared all the variables (with pointers) in the "TModule" and "create" functions and then i use them in the "process".
Now it seems to work fine.
But it's strange: i tried to do a simpler object with just one variable declared in the "process" without pointer (just for testing).
If i create 2 instances of this object the variable is not shared, while in my more complex "cycle" object, 2 instances share the variables with the same name...why?
however thanks
Statistics: Posted by Gizzeta — 07 May 2009, 19:11
]]>
the buffer pointer variable seems ok,
the use of fread too,
the only thing not very clean is that :
CODE:
int* lSize;CODE:
int lSize;CODE:
void Create(void* &pModule) { pModule = new TCycle(); TCycle* pCycle = ((TCycle*)pModule); size_t result; // no more needed // pCycle->lSize = new int; pCycle->pFile = fopen ( "E:\AUDIO\USINEfiles\Cycle\Sine2048.bin" , "rb" ); assert(pCycle->pFile != NULL); //obtain file size: fseek (pCycle->pFile , 0 , SEEK_END); // no more * indirection pCycle->lSize = ftell (pCycle->pFile); pCycle->lSize /= sizeof(float); rewind (pCycle->pFile); // allocate memory to contain the whole file: // especially this line was maybe missinterpreted before, it's better like that pCycle->buffer = new float[sizeof(float) * pCycle->lSize]; // copy the file into the buffer: result = fread (pCycle->buffer, sizeof(float), pCycle->lSize, pCycle->pFile); //close fclose (pCycle->pFile);}CODE:
pCycle->buffer = new float[sizeof(float)**pCycle->lSize];but other than that, it's seems ok.
Statistics: Posted by martignasse — 07 May 2009, 17:15
]]>
]]>
Statistics: Posted by senso — 07 May 2009, 09:01
]]>
I declared the variables in the TModule class declaration:
CODE:
class TCycle : public TUserModule{public:// Declare all parameters events pointers needed, example :TEVT* pFreqIn;TEVT* pAudioOut;TEVT* ARR;FILE* pFile;float* buffer;int* lSize;};CODE:
void Create(void* &pModule) {pModule = new TCycle();TCycle* pCycle = ((TCycle*)pModule);size_t result;pCycle->lSize = new int;pCycle->pFile = fopen ( "E:\AUDIO\USINEfiles\Cycle\Sine2048.bin" , "rb" );assert(pCycle->pFile != NULL);//obtain file size:fseek (pCycle->pFile , 0 , SEEK_END);*pCycle->lSize = ftell (pCycle->pFile);*pCycle->lSize /= sizeof(float);rewind (pCycle->pFile);// allocate memory to contain the whole file:pCycle->buffer = new float[sizeof(float)**pCycle->lSize];// copy the file into the buffer:result = fread (pCycle->buffer,sizeof(float),*pCycle->lSize,pCycle->pFile); //closefclose (pCycle->pFile);}thanks
Statistics: Posted by Gizzeta — 07 May 2009, 00:11
]]>
so try to create them into the TModule object declaration.
Statistics: Posted by senso — 05 May 2009, 18:56
]]>
Sorry for the lag, i saw you'r question but have to take the train to go to the electrolyse days (was so geat
).There is no static or global variable exposed in the SDK actually, so it's not coming from here.
We have to confirm with Senso if there is some at usine level (not exposed at SDK level), but even if there is some, it shouldn't make problem with a user buffer declared at the SDK level.
I tested with two instances of the C++ DrawPad user module and there is no problems with the point buffer.
Anyway, it's difficult to answer or help without some code for this kind of problem. It would be interesting to see how you declare, init and modify you'r buffer.
Statistics: Posted by martignasse — 05 May 2009, 18:03
]]>
hi,
need help again...
I create a module that fill a buffer with a waveform stored in an external file and read it as a loop (oscillator).
it works nice, but when I add a second instance of the same module (even if not connected) it affect the output of the first module (it sounds like a frequency modulation). WHY???
Normally all the variables and pointers are internals to every instance of the module(private)...or not?
Thanks for your help
need help again...
I create a module that fill a buffer with a waveform stored in an external file and read it as a loop (oscillator).
it works nice, but when I add a second instance of the same module (even if not connected) it affect the output of the first module (it sounds like a frequency modulation). WHY???
Normally all the variables and pointers are internals to every instance of the module(private)...or not?
Thanks for your help
Statistics: Posted by martignasse — 05 May 2009, 17:47
]]>